Resolve reviews

Signed-off-by: divyansh42 <diagrawa@redhat.com>
This commit is contained in:
divyansh42 2021-04-09 19:28:36 +05:30
parent 6c8dd380f7
commit 133ced04cc
4 changed files with 9 additions and 5 deletions

2
dist/index.js vendored

File diff suppressed because one or more lines are too long

2
dist/index.js.map vendored

File diff suppressed because one or more lines are too long

View file

@ -43,9 +43,13 @@ export class BuildahCli implements Buildah {
this.storageOptsEnv = `overlay.mount_program=${fuseOverlayfsPath}`; this.storageOptsEnv = `overlay.mount_program=${fuseOverlayfsPath}`;
} }
else { else {
core.warning(`"fuse-overlayfs" is not found. Install it before running this action`); core.warning(`"fuse-overlayfs" is not found. Install it before running this action.`
+ `For more detail see https://github.com/redhat-actions/buildah-build/issues/45`);
} }
} }
else {
core.info("Storage driver is not 'overlay', so not overriding storage configuration");
}
} }
private static getImageFormatOption(useOCI: boolean): string[] { private static getImageFormatOption(useOCI: boolean): string[] {

View file

@ -43,8 +43,8 @@ async function fileExists(filePath: string): Promise<boolean> {
} }
} }
export async function findFuseOverlayfsPath(): Promise<string> { export async function findFuseOverlayfsPath(): Promise<string | undefined> {
let fuseOverlayfsPath = ""; let fuseOverlayfsPath;
try { try {
fuseOverlayfsPath = await io.which("fuse-overlayfs"); fuseOverlayfsPath = await io.which("fuse-overlayfs");
} }