mirror of
https://github.com/redhat-actions/buildah-build.git
synced 2025-06-08 10:01:34 +00:00
Add draft implementation of 'platform' argument support
This commit is contained in:
parent
f123b1f960
commit
0c97e9954d
4 changed files with 30 additions and 8 deletions
|
@ -15,12 +15,13 @@ export interface BuildahConfigSettings {
|
||||||
port?: string;
|
port?: string;
|
||||||
workingdir?: string;
|
workingdir?: string;
|
||||||
arch?: string;
|
arch?: string;
|
||||||
|
platform?: string;
|
||||||
}
|
}
|
||||||
|
|
||||||
interface Buildah {
|
interface Buildah {
|
||||||
buildUsingDocker(
|
buildUsingDocker(
|
||||||
image: string, context: string, containerFiles: string[], buildArgs: string[],
|
image: string, context: string, containerFiles: string[], buildArgs: string[],
|
||||||
useOCI: boolean, arch: string, layers: string, extraArgs: string[]
|
useOCI: boolean, arch: string, platform: string, layers: string, extraArgs: string[]
|
||||||
): Promise<CommandResult>;
|
): Promise<CommandResult>;
|
||||||
from(baseImage: string): Promise<CommandResult>;
|
from(baseImage: string): Promise<CommandResult>;
|
||||||
config(container: string, setting: BuildahConfigSettings): Promise<CommandResult>;
|
config(container: string, setting: BuildahConfigSettings): Promise<CommandResult>;
|
||||||
|
@ -63,13 +64,17 @@ export class BuildahCli implements Buildah {
|
||||||
|
|
||||||
async buildUsingDocker(
|
async buildUsingDocker(
|
||||||
image: string, context: string, containerFiles: string[], buildArgs: string[],
|
image: string, context: string, containerFiles: string[], buildArgs: string[],
|
||||||
useOCI: boolean, arch: string, layers: string, extraArgs: string[]
|
useOCI: boolean, arch: string, platform: string, layers: string, extraArgs: string[]
|
||||||
): Promise<CommandResult> {
|
): Promise<CommandResult> {
|
||||||
const args: string[] = [ "bud" ];
|
const args: string[] = [ "bud" ];
|
||||||
if (arch) {
|
if (arch) {
|
||||||
args.push("--arch");
|
args.push("--arch");
|
||||||
args.push(arch);
|
args.push(arch);
|
||||||
}
|
}
|
||||||
|
if (platform) {
|
||||||
|
args.push("--platform");
|
||||||
|
args.push(platform);
|
||||||
|
}
|
||||||
containerFiles.forEach((file) => {
|
containerFiles.forEach((file) => {
|
||||||
args.push("-f");
|
args.push("-f");
|
||||||
args.push(file);
|
args.push(file);
|
||||||
|
@ -135,6 +140,10 @@ export class BuildahCli implements Buildah {
|
||||||
args.push("--arch");
|
args.push("--arch");
|
||||||
args.push(settings.arch);
|
args.push(settings.arch);
|
||||||
}
|
}
|
||||||
|
if (settings.platform) {
|
||||||
|
args.push("--platform");
|
||||||
|
args.push(settings.platform);
|
||||||
|
}
|
||||||
if (settings.workingdir) {
|
if (settings.workingdir) {
|
||||||
args.push("--workingdir");
|
args.push("--workingdir");
|
||||||
args.push(settings.workingdir);
|
args.push(settings.workingdir);
|
||||||
|
|
|
@ -12,6 +12,12 @@ export enum Inputs {
|
||||||
* Default: None.
|
* Default: None.
|
||||||
*/
|
*/
|
||||||
ARCHS = "archs",
|
ARCHS = "archs",
|
||||||
|
/**
|
||||||
|
* Label the image with this PLATFORM, instead of defaulting to the host platform.
|
||||||
|
* Required: false
|
||||||
|
* Default: None.
|
||||||
|
*/
|
||||||
|
PLATFORM = "platform",
|
||||||
/**
|
/**
|
||||||
* The base image to use to create a new container image
|
* The base image to use to create a new container image
|
||||||
* Required: false
|
* Required: false
|
||||||
|
|
15
src/index.ts
15
src/index.ts
|
@ -9,7 +9,7 @@ import * as path from "path";
|
||||||
import { Inputs, Outputs } from "./generated/inputs-outputs";
|
import { Inputs, Outputs } from "./generated/inputs-outputs";
|
||||||
import { BuildahCli, BuildahConfigSettings } from "./buildah";
|
import { BuildahCli, BuildahConfigSettings } from "./buildah";
|
||||||
import {
|
import {
|
||||||
getArch, getContainerfiles, getInputList, splitByNewline,
|
getArch, getPlatform, getContainerfiles, getInputList, splitByNewline,
|
||||||
} from "./utils";
|
} from "./utils";
|
||||||
|
|
||||||
export async function run(): Promise<void> {
|
export async function run(): Promise<void> {
|
||||||
|
@ -43,12 +43,13 @@ export async function run(): Promise<void> {
|
||||||
const useOCI = core.getInput(Inputs.OCI) === "true";
|
const useOCI = core.getInput(Inputs.OCI) === "true";
|
||||||
|
|
||||||
const arch = getArch();
|
const arch = getArch();
|
||||||
|
const platform = getPlatform();
|
||||||
|
|
||||||
if (containerFiles.length !== 0) {
|
if (containerFiles.length !== 0) {
|
||||||
await doBuildUsingContainerFiles(cli, newImage, workspace, containerFiles, useOCI, arch);
|
await doBuildUsingContainerFiles(cli, newImage, workspace, containerFiles, useOCI, arch, platform);
|
||||||
}
|
}
|
||||||
else {
|
else {
|
||||||
await doBuildFromScratch(cli, newImage, useOCI, arch);
|
await doBuildFromScratch(cli, newImage, useOCI, arch, platform);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (tagsList.length > 1) {
|
if (tagsList.length > 1) {
|
||||||
|
@ -60,7 +61,8 @@ export async function run(): Promise<void> {
|
||||||
}
|
}
|
||||||
|
|
||||||
async function doBuildUsingContainerFiles(
|
async function doBuildUsingContainerFiles(
|
||||||
cli: BuildahCli, newImage: string, workspace: string, containerFiles: string[], useOCI: boolean, arch: string
|
cli: BuildahCli, newImage: string, workspace: string, containerFiles: string[], useOCI: boolean, arch: string,
|
||||||
|
platform: string
|
||||||
): Promise<void> {
|
): Promise<void> {
|
||||||
if (containerFiles.length === 1) {
|
if (containerFiles.length === 1) {
|
||||||
core.info(`Performing build from Containerfile`);
|
core.info(`Performing build from Containerfile`);
|
||||||
|
@ -83,12 +85,12 @@ async function doBuildUsingContainerFiles(
|
||||||
buildahBudExtraArgs = lines.flatMap((line) => line.split(" ")).map((arg) => arg.trim());
|
buildahBudExtraArgs = lines.flatMap((line) => line.split(" ")).map((arg) => arg.trim());
|
||||||
}
|
}
|
||||||
await cli.buildUsingDocker(
|
await cli.buildUsingDocker(
|
||||||
newImage, context, containerFileAbsPaths, buildArgs, useOCI, arch, layers, buildahBudExtraArgs
|
newImage, context, containerFileAbsPaths, buildArgs, useOCI, arch, platform, layers, buildahBudExtraArgs
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
async function doBuildFromScratch(
|
async function doBuildFromScratch(
|
||||||
cli: BuildahCli, newImage: string, useOCI: boolean, arch: string
|
cli: BuildahCli, newImage: string, useOCI: boolean, arch: string, platform: string
|
||||||
): Promise<void> {
|
): Promise<void> {
|
||||||
core.info(`Performing build from scratch`);
|
core.info(`Performing build from scratch`);
|
||||||
|
|
||||||
|
@ -108,6 +110,7 @@ async function doBuildFromScratch(
|
||||||
workingdir: workingDir,
|
workingdir: workingDir,
|
||||||
envs,
|
envs,
|
||||||
arch,
|
arch,
|
||||||
|
platform,
|
||||||
};
|
};
|
||||||
await cli.config(containerId, newImageConfig);
|
await cli.config(containerId, newImageConfig);
|
||||||
await cli.copy(containerId, content);
|
await cli.copy(containerId, content);
|
||||||
|
|
|
@ -81,6 +81,10 @@ export function getArch(): string {
|
||||||
return arch || archs;
|
return arch || archs;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export function getPlatform(): string {
|
||||||
|
return core.getInput(Inputs.PLATFORM);
|
||||||
|
}
|
||||||
|
|
||||||
export function getContainerfiles(): string[] {
|
export function getContainerfiles(): string[] {
|
||||||
// 'containerfile' should be used over 'dockerfile',
|
// 'containerfile' should be used over 'dockerfile',
|
||||||
// see https://github.com/redhat-actions/buildah-build/issues/57
|
// see https://github.com/redhat-actions/buildah-build/issues/57
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue